fix(lib): Correct types for allowedAccountIds & forbiddenAccountIds in S3Backend #3669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Booligoosh
requested review from
mutahhir and
ansgarm
and removed request for
a team
|
|
ansgarm
changed the title
ansgarm
force-pushed
the
s3-account-ids-type-fix
branch
from
6f9a45a
to
da92239
Compare
ansgarm
force-pushed
the
s3-account-ids-type-fix
branch
from
da92239
to
021ddbb
Compare
ansgarm
force-pushed
the
s3-account-ids-type-fix
branch
from
021ddbb
to
4bfeb99
Compare
…Config to string[] to match Terraform When providing these fields as a string rather than a list of strings, Terraform throws an error.
ansgarm
force-pushed
the
s3-account-ids-type-fix
branch
from
4bfeb99
to
0643ab4
Compare
|
Thanks for merging! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
No related issue as it is only a simple 2-line change. Can create one if required.
Description
When providing these fields as a string rather than a list of strings, Terraform throws an error. This PR updates the types to be a list of strings, to allow specifying the format that Terraform requires (similar to the other S3BackendConfig keys such as sharedConfigFiles, sharedCredentialsFiles etc).
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentation if applicableI have added tests that prove my fix is effective or that my feature works if applicable